Conversation
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Member
|
While reviewing this and making minor corrections and improvements: I am not sure why howto.md should be separate from readme.md. Is there a reason not to just merge the contents of howto.md into readme.md and delete howto.md? |
Member
|
Is the docker image being updated? I glanced at quay.io/gaocegege/processing.r and it showed auto-builds from master that are only a few hours old. I didn't try it. |
Member
Author
|
LGTM, quay.io/gaocegege/processing.r is just like Travis, it builds the new docker image automatically, but we still can not run 3D sketches in the docker container. It is deprecated but the source code in docker is the most updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this PR needs your review @jeremydouglass
Changes Preview
Close #159 🙏
Signed-off-by: Ce Gao ce.gao@outlook.com