Skip to content

fix: address top open issues (links, z-index, x.com URL)#880

Merged
tannerlinsley merged 1 commit intomainfrom
claude/fix-issues-WLcJy
Apr 30, 2026
Merged

fix: address top open issues (links, z-index, x.com URL)#880
tannerlinsley merged 1 commit intomainfrom
claude/fix-issues-WLcJy

Conversation

@tannerlinsley
Copy link
Copy Markdown
Member

@tannerlinsley tannerlinsley commented Apr 30, 2026

Summary

Test plan

  • pnpm test (tsc + oxlint) passes
  • Verify in docs that the "+" feedback button no longer covers the fixed top navbar
  • Verify .agents/index.md links resolve correctly when viewed on GitHub
  • Verify Footer X.com link clicks through to x.com/tannerlinsley

https://claude.ai/code/session_01TYh6hJQmzvmWMpBfg8uhdt


Generated by Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated links in documentation to reference resources correctly
  • Chores
    • Adjusted floating feedback button's visual layer priority
    • Updated footer social media profile link to current platform

- #822: relative links inside .agents/index.md now use ./ since the
  file is loaded directly via .agents/index.md (CLAUDE.md is a symlink
  to it), so .agents/typescript.md resolved to .agents/.agents/...
  Matches the fix in PR #820.
- #730: docs DocFeedbackFloatingButton dropped from z-[100] to z-30 so
  the floating "+" no longer overlaps the navbar (also at z-[100]).
- #281 follow-up: Footer link labelled "@tannerlinsley on X.com" now
  points to x.com instead of twitter.com to match its label and the
  rest of the site's X.com migration.

https://claude.ai/code/session_01TYh6hJQmzvmWMpBfg8uhdt
@tannerlinsley tannerlinsley merged commit 61c45aa into main Apr 30, 2026
3 of 4 checks passed
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 30, 2026

Deploy Preview for tanstack ready!

Name Link
🔨 Latest commit a29ef2b
🔍 Latest deploy log https://app.netlify.com/projects/tanstack/deploys/69f3c3124dd2470008ab0759
😎 Deploy Preview https://deploy-preview-880--tanstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 28
Accessibility: 90
Best Practices: 75
SEO: 97
PWA: 70
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@tannerlinsley tannerlinsley deleted the claude/fix-issues-WLcJy branch April 30, 2026 21:01
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 30, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 66bef2a0-4005-416f-88c1-3f434071df96

📥 Commits

Reviewing files that changed from the base of the PR and between 8c11a33 and a29ef2b.

📒 Files selected for processing (3)
  • .agents/index.md
  • src/components/DocFeedbackFloatingButton.tsx
  • src/components/Footer.tsx

📝 Walkthrough

Walkthrough

Three files were updated: markdown documentation links corrected from nested to sibling paths, a floating button component's z-index reduced from z-[100] to z-30, and a footer social media link updated from twitter.com to x.com.

Changes

Cohort / File(s) Summary
Documentation Links
.agents/index.md
Updated markdown link references from .agents/*.md to ./*.md paths for Typesafety guideline and Topic Guides sections.
Component Updates
src/components/DocFeedbackFloatingButton.tsx, src/components/Footer.tsx
Reduced floating button z-index from z-[100] to z-30 and updated footer X.com social link URL from twitter.com to x.com.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Whiskers twitching with delight,
Links now point where paths are right,
Z-index tucked in layer low,
X.com shines with fresh-faced glow!
Tiny tweaks that make things bright!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/fix-issues-WLcJy

Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants