Swift: Replace two additional taint steps with implicit reads#14357
Merged
geoffw0 merged 3 commits intogithub:mainfrom Oct 3, 2023
Merged
Swift: Replace two additional taint steps with implicit reads#14357geoffw0 merged 3 commits intogithub:mainfrom
geoffw0 merged 3 commits intogithub:mainfrom
Conversation
Now that we have array content, this is a more principled approach than having a special case data step.
MathiasVP
approved these changes
Oct 3, 2023
Contributor
MathiasVP
left a comment
There was a problem hiding this comment.
The changes LGTM! We should probably run DCA before we merge this, though
Contributor
Author
|
DCA LGTM. Merging. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace additional taint steps in
swift/command-line-injectionandswift/cleartext-storage-databasewith implicit reads instead. Implicit reads are a more principled / accurate way of doing data flow out from array elements at the sink (now that we model array content and it can work).Note that in the test changes, the
#selectparts are unaffected.