Use jnp.zeros rather than jnp.empty in places where values are important.#51
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Use jnp.zeros rather than jnp.empty in places where values are important.#51copybara-service[bot] wants to merge 1 commit intomainfrom
jnp.zeros rather than jnp.empty in places where values are important.#51copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
…portant. Why? JAX has always lowered `jnp.empty` to `jnp.zeros`, because in early versions of XLA there was no way to create an uninitialized buffer. In a future JAX release, `jnp.empty` will lower to `jax.lax.empty`, which creates an uninitialized buffer. This is closer to the intent of `jnp.empty`, and can lead to more efficient code when the author knows that initializing the array is not required. These problematic uses were detected by temporarily making `jnp.empty` return `NaN` (for float & complex dtypes) or the maximum value (for int and bool dtypes), and running global presubmit tests. PiperOrigin-RevId: 900399273
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
jnp.zerosrather thanjnp.emptyin places where values are important.Why? JAX has always lowered
jnp.emptytojnp.zeros, because in early versions of XLA there was no way to create an uninitialized buffer. In a future JAX release,jnp.emptywill lower tojax.lax.empty, which creates an uninitialized buffer. This is closer to the intent ofjnp.empty, and can lead to more efficient code when the author knows that initializing the array is not required.These problematic uses were detected by temporarily making
jnp.emptyreturnNaN(for float & complex dtypes) or the maximum value (for int and bool dtypes), and running global presubmit tests.