Skip to content

Fix Intl.Collator compare declaration#63449

Closed
afurm wants to merge 1 commit intomicrosoft:mainfrom
afurm:af/fix-intl-collator-compare
Closed

Fix Intl.Collator compare declaration#63449
afurm wants to merge 1 commit intomicrosoft:mainfrom
afurm:af/fix-intl-collator-compare

Conversation

@afurm
Copy link
Copy Markdown

@afurm afurm commented Apr 29, 2026

Fixes #62048

Summary

  • Model Intl.Collator#compare as a readonly function-valued property with this: void.
  • Add a compiler baseline test covering direct bound-function usage, rejection of this-dependent replacements, and readonly assignment behavior.

Validation

  • There is an associated issue in the Backlog milestone
  • Code is up-to-date with the main branch
  • Ran hereby runtests locally:
    • npx hereby runtests --tests=intlCollatorCompareAccessor --runner=compiler
    • npx hereby runtests --tests=localesObjectArgument --runner=compiler
  • There are new or updated unit tests validating the change

AI Assistance

This PR was authored with assistance from OpenAI Codex.

Copilot AI review requested due to automatic review settings April 29, 2026 18:55
@github-project-automation github-project-automation Bot moved this to Not started in PR Backlog Apr 29, 2026
@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Apr 29, 2026
@jakebailey
Copy link
Copy Markdown
Member

I don't think we need a second PR for this: #62052

@afurm
Copy link
Copy Markdown
Author

afurm commented Apr 29, 2026

@afurm please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree [company="{Andrii Furmanets"]
@microsoft-github-policy-service agree
@microsoft-github-policy-service agree company="Microsoft"

@afurm
Copy link
Copy Markdown
Author

afurm commented Apr 29, 2026

@afurm the command you issued was incorrect. Please try again.

Examples are:

@microsoft-github-policy-service agree

and

@microsoft-github-policy-service agree company="your company"

@microsoft-github-policy-service agree
@microsoft-github-policy-service agree company="Andrii Furmanets"

@afurm
Copy link
Copy Markdown
Author

afurm commented Apr 29, 2026

Closing this because I noticed #62052 already covers #62048. Sorry for the duplicate.

@afurm afurm closed this Apr 29, 2026
@github-project-automation github-project-automation Bot moved this from Not started to Done in PR Backlog Apr 29, 2026
@afurm afurm review requested due to automatic review settings April 29, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Intl.Collator#compare method type does not match spec

3 participants