Conversation
jeremydouglass
requested changes
Jun 8, 2017
Member
jeremydouglass
left a comment
There was a problem hiding this comment.
sphereDetail1x.rpde and its sketch.properties can be dropped from the merge.
That is a broken sketch that I left in the branch on accident.
f78dee5 to
2dca61b
Compare
…args to beginShape / endShape)
…n constants and variables)
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Ce Gao <ce.gao@outlook.com>
2dca61b to
14a05a3
Compare
Member
Author
|
Finished PTAL @jeremydouglass |
Signed-off-by: Ce Gao <ce.gao@outlook.com>
…ken examples (bezierDetail1x, curveDetail1x)
jeremydouglass
approved these changes
Jun 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, @jeremydouglass
The automation of documentation and test is ready, so I think it is time to merge the sketches in this branch, WDYT
👍