Conversation
eb7ca43 to
6237b80
Compare
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Ce Gao <ce.gao@outlook.com>
6237b80 to
4746a38
Compare
|
PTAL @jeremydouglass @hawkingrei I am not confident in my English 🤔 |
There was a problem hiding this comment.
This is a very good draft! The important details are here, it is well organized, and the English is clear. My main feedback:
- Order of the overview: Say what this project is immediately, then give background on what Processing is. Currently the project is introduced on the fourth paragraph, this is confusing.
- There are a few typos, like "skectches." Run spellcheck before submitting.
- Some of the English could be slightly improved.
Rather than give details, I will add a commit.
...plus, I think architecture needs to be re-organized to be more clear. Adding an additional commit -- please read and see if this is an improvement.
Reorganize introduction, small changes.
Reorganize Architecture section, group in logical order by common/jar/pde, expand descriptions.
|
|
||
| #### `ModeService` and `SketchServiceManager` | ||
|
|
||
| `ModeService` is a Remote Method Invocation(RMI) interface, which extends `java.rmi.Remote`. `SketchServiceManager` is the class which implements `ModeService`. `RLangMode` creates a `SketchServiceManager` instance when started. `SketchServiceManager` manages all `SketchServiceRunner`s, and `SketchServiceRunner` runs the real logic of Processing.R sketches. |
There was a problem hiding this comment.
Not sure I understand. Is this sed for changing to "an Remote Method Invocation" and "an SketchServiceManager" ? Those changes aren't needed.
"a" comes before closed consonant letters and sounds here like "Remote" and "Sketch", "an" would come before open vowel letters and sounds like "Interface" or "Extends."
There was a problem hiding this comment.
OK, I got it! I thought we need to change from a Remote to an Remote.
There was a problem hiding this comment.
In spoken English, people would say "a Remote" (AY reemOHT). However, they would say "an R.M.I." (AAN AHR-EHM-IY). Changing "a" to "an" is a way to keep the two vowel sounds (AY AHR) from blending together.
|
LGTM 🎉 |
Close #119
Signed-off-by: Ce Gao ce.gao@outlook.com