feat: move the function about mouse to BuiltinApplet#126
Merged
gaocegege merged 1 commit intoprocessing-r:masterfrom Jun 18, 2017
hawkingrei:feat/move_function_to_BuiltinApplet
Merged
feat: move the function about mouse to BuiltinApplet#126gaocegege merged 1 commit intoprocessing-r:masterfrom hawkingrei:feat/move_function_to_BuiltinApplet
gaocegege merged 1 commit intoprocessing-r:masterfrom
hawkingrei:feat/move_function_to_BuiltinApplet
Conversation
Member
|
LGTM! Thanks for your contribution. |
Member
jeremydouglass
left a comment
There was a problem hiding this comment.
RLangPApplet already imports BuiltInApplet, so copying imports from RLangPApplet into BuiltInApplet means duplicate import statements. Why?
| import org.renjin.sexp.StringVector; | ||
|
|
||
| import processing.core.PApplet; | ||
| import rprocessing.exception.NotFoundException; |
Member
There was a problem hiding this comment.
This block of import statements are being added to BuiltinApplet, but not removed from RLangPApplet.
Contributor
Author
There was a problem hiding this comment.
I removed the useless import #127
this block of import statements doesn't remove from RLangPApplet. When the RLangPApplet initializes, it will be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the function to BuiltinApplet