Conversation
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Member
There was a problem hiding this comment.
I really like this ImportLibrary reference example!
I would recommend renaming the "Basics" sketch to "LibraryBasics" (and from a separate merge, the other "Basics" to "RPackageBasics") to avoid confusion -- both with each other and with a true basic sketch.
Especially with library basics, a new user might accidentally open a sketch named "Basics" from the examples menu and try to run it -- assuming that it will demonstrate core features of the mode. However the sketch will not work unless peasycam has been installed separately. The user may then conclude that Processing.R doesn't work.
Member
Author
|
OK, I will rename it, too. Thanks for the suggestion! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ce Gao ce.gao@outlook.com