Skip to content

*: Fix the callback function#187

Merged
gaocegege merged 1 commit intomasterfrom
builtin/callback
Jul 26, 2017
Merged

*: Fix the callback function#187
gaocegege merged 1 commit intomasterfrom
builtin/callback

Conversation

@gaocegege
Copy link
Copy Markdown
Member

Close #163

Signed-off-by: Ce Gao ce.gao@outlook.com

Signed-off-by: Ce Gao <ce.gao@outlook.com>
@gaocegege gaocegege merged commit 5bad9e3 into master Jul 26, 2017
@gaocegege gaocegege deleted the builtin/callback branch July 26, 2017 11:27
@jeremydouglass
Copy link
Copy Markdown
Member

Wow. What is this change doing? Is this a core solution based on a renjin feature?

@gaocegege
Copy link
Copy Markdown
Member Author

It is the similar idea with settings and draw. We will evaluate the function definition and when the specific function is called, try to find the definition in R and call it.

@jeremydouglass
Copy link
Copy Markdown
Member

I see. I didn't look carefully enough -- I can see that this is a specific mapping for each interactivity callback, not a general method of discovering them. Still, this is great! Having interactivity support is huge for Processing -- so much example code all uses these functions.

Perhaps we should add a few interactive test sketches to the reference during testing of these new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants