Conversation
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Member
|
Great! The reference documentation should also be updated. Currently we have the examples for mousePressed (function and variable) both on the same page. There are also old cross-references listing mousePressed_var with an underscore. Instead, there should be two pages, one for mousePressed, one for mousePressedVar (with separate examples), and no mentions of mousePressed_var. Can keyPressed / keyPressedVar and references be updated in the same way? |
Member
Author
|
Yeah, of course. |
Signed-off-by: Ce Gao <ce.gao@outlook.com>
Member
|
Looks good. Good attention to detail, making sure that the new "Var" entries appear in .property.yml "related:" lists. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #194 and ref #185