search: cache index per locale and tighten iframe postMessage origin #1350
Open
avinxshKD wants to merge 2 commits intoprocessing:mainfrom
Open
search: cache index per locale and tighten iframe postMessage origin #1350avinxshKD wants to merge 2 commits intoprocessing:mainfrom
avinxshKD wants to merge 2 commits intoprocessing:mainfrom
Conversation
Author
|
@ksen0 @doradocodes pls take a look, kept focused fixes as discussed (search fetch/index flow + postMessage origin hardening) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the search flow to fetch/build the index only when locale changes, reuse the same Fuse instance for typing with a small debounce, and abort stale fetches, and it also removes wildcard postMessage usage by using same-origin target/checks.
I’m sending this as a small perf/safety cleanup for #1249 since the p5.sound part looks outdated now, but the repeated search work and loose messaging behavior were still valid to fix.
Refs #1249