Fix: allow setting output in mypy.ini / mypy.toml#21398
Open
tjhub1983 wants to merge 4 commits intopython:masterfrom
Open
Fix: allow setting output in mypy.ini / mypy.toml#21398tjhub1983 wants to merge 4 commits intopython:masterfrom
output in mypy.ini / mypy.toml#21398tjhub1983 wants to merge 4 commits intopython:masterfrom
Conversation
Python 3 allows calling NoneType() and type(None)():
>>> NoneType()
None
>>> type(None)()
None
But mypy raised an "unsupported_type_type" error in analyze_type_type_callee
when encountering a Type[None] callee. Fixed by adding isinstance(item, NoneType)
branch that returns a zero-argument CallableType returning NoneType.
Fixes python#19660.
for more information, see https://pre-commit.ci
`output` in Options defaults to None (meaning unset). The config parser skips options when getattr(template, key, None) returns None, so `output = json` in mypy.ini was silently ignored. Fixed by adding `"output": str` to both ini_config_types and toml_config_types, so the option is recognized and properly set. Fixes python#21376.
`output` in Options defaults to None. The config parser skips options when getattr(template, key, None) returns None, so `output = json` in mypy.ini was silently ignored. Fixed by adding `"output": str` to both ini_config_types and toml_config_types. Fixes python#21376.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
outputoption (e.g.,output = json) inmypy.iniormypy.tomlwas silently ignored.Root cause:
Options.outputdefaults toNone. The config parser checksdv = getattr(template, key, None)and skips options whendv is None.Since
outputwas not inconfig_types, it fell through and was silently ignored.Fix: Add
"output": strto bothini_config_typesandtoml_config_types.Changes
mypy/config_parser.py: added"output": strtoini_config_typesandtoml_config_typesTesting
Now correctly produces JSON output.
Fixes #21376.