Conversation
59fcae7 to
8eeb050
Compare
8eeb050 to
d0018ac
Compare
added 2 commits
January 31, 2024 23:07
lincoln-replit
approved these changes
Feb 1, 2024
lincoln-replit
left a comment
There was a problem hiding this comment.
Guess I started a review yesterday but forgot to finish it!
| """ | ||
| self.__object(dest_object_name).upload_from_filename(src_filename) | ||
|
|
||
| def upload_from_text(self, dest_object_name: str, src_data: str) -> None: |
There was a problem hiding this comment.
Suggested change
| def upload_from_text(self, dest_object_name: str, src_data: str) -> None: | |
| def upload_from_string(self, dest_object_name: str, src_data: str) -> None: |
Small nit to match the underlying library
Contributor
Author
There was a problem hiding this comment.
I opted to go this route for symmetry, from what I can tell the only reason they don't match is because download_as_string is a deprecated alias for download_as_bytes in the GCS library
Re-reading this I like the string one better, going to change both to that
| """ | ||
| return self.__object(object_name).delete() | ||
|
|
||
| def download_as_bytes(self, object_name: str) -> bytes: |
There was a problem hiding this comment.
Is there an equivalent upload_from_bytes function that could be added for symmetry?
Contributor
Author
There was a problem hiding this comment.
For some reason no, I'll look into adding an equivalent (probably as a follow-up)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get the library into a testable, buildable state, and provide implementations of some methods.
This is not representative of the intended feature-set of the first release of the library but the first release is expected to follow this general structure.