chore: clean up stranded .server-changes/ files from v4.4.5#3509
Merged
chore: clean up stranded .server-changes/ files from v4.4.5#3509
Conversation
Cleanup workflow stranded these files when v4.4.5 (#3406) was merged: the changesets-pr workflow's cancel-in-progress concurrency policy killed the update-lockfile job (which holds the .server-changes/ cleanup step) on the post-merge run. PR #3505 fixes the underlying race by collapsing the cleanup into changeset:version itself; this PR clears the leftover files so the v4.4.6 release PR (#3501) only lists genuinely new server changes. Keeps fix-rollback-schedule-sync.md (#3468) — that is the only server change new in 4.4.6.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (34)
💤 Files with no reviewable changes (34)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (31)
WalkthroughThis pull request removes or blanks out documentation entries from approximately 30 server changelog files located in the Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
matt-aitken
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delete 34
.server-changes/*.mdfiles that should have been cleaned up automatically when v4.4.5 (#3406) was merged but were stranded by a workflow race.Why these are stale
The
update-lockfilejob in.github/workflows/changesets-pr.ymlis what cleans up consumed.server-changes/*.mdfiles on the release branch. When v4.4.5 was merged on 2026-05-01, the post-merge workflow run onmainfailed atpnpm install --frozen-lockfile(stale lockfile in the merge commit), andcancel-in-progress: truecancelled the in-flight run from the previous push — soupdate-lockfilenever reached the cleanup step.Result: the 34 files described changes that v4.4.5 already shipped, and they were re-appearing in the v4.4.6 release PR (#3501) under "Server changes" plus showing up as deletions in its diff.
What this PR keeps
fix-rollback-schedule-sync.md— genuinely new for v4.4.6 (fix: sync declarative schedules on deployment rollback #3468), the only server change introduced after v4.4.5README.md,.gitkeep— directory infrastructuredev-cli-disconnect-md— leaving alone (typo'd filename from March, no.mdextension, not picked up by the cleanup glob anyway)After merge
The next run of
changesets-pr.ymlwill refresh #3501 with a "Server changes" section that only lists the v4.4.6 entry, and the only.server-changes/deletion in its diff will befix-rollback-schedule-sync.md.Related
changesets/actionso this race can't strand the cleanup again. This PR is just the one-time catch-up for the files that already got stranded.